Skip to content
This repository was archived by the owner on Apr 25, 2025. It is now read-only.

feat!: Add support for sync operations #20

Merged
merged 89 commits into from
Mar 13, 2025
Merged

Conversation

twishabansal
Copy link
Contributor

@twishabansal twishabansal commented Feb 25, 2025

Corresponding README updates in #22

kurtisvg and others added 30 commits February 17, 2025 22:34
This PR improves session cleanup by using `asyncio.get_running_loop` instead of `asyncio.get_event_loop`. The latter is deprecated and has been known to cause complications. If no running loop is found, then a `RuntimeError` is thrown and caught, and a new event loop is spun up to close the session.

Key changes:
* Use `asyncio.get_running_loop` instead of `asyncio.get_event_loop`.
* Catch and handle a specific `RuntimeError` that can occur if no running loop is found.
* Spin up a new event loop to close the session if no running loop is found.
@twishabansal twishabansal changed the base branch from twisha-bound-params to main March 3, 2025 03:29
@twishabansal twishabansal requested a review from anubhav756 March 3, 2025 12:28
@twishabansal twishabansal merged commit 1fa45af into main Mar 13, 2025
9 checks passed
@twishabansal twishabansal deleted the twisha-sync-client branch March 13, 2025 05:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants